Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: improve debug configuration behavior for multi-root workspaces #12674

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

Maddobun
Copy link
Contributor

@Maddobun Maddobun commented Jun 30, 2023

What it does

This PR fixes #12663 and introduces improvements to the theia debug widget:

  • debug configuration dropdown now listen to changes in workspace root. If a root is added or removed for a multi-root project, the debug widget will refresh to reflect the change.
  • the open launch.json button now opens the configuration selected in the drop down menu instead of the first root folder configuration.

How to test

  • Open a multi-root work space. Verify that launch configuration for each root show up in the debug dropdown
  • Remove one of the root folder by right click -> remove folder from workspace
  • Verify that the associated launch configuration disappears
  • Verify that open launch.json button opens the configuration selected in the drop down menu

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

@vince-fugnitto vince-fugnitto changed the title Address #12663 and other improvement debug: improve debug configuration behavior for multi-root workspaces Jul 13, 2023
@vince-fugnitto vince-fugnitto added debug issues that related to debug functionality multi-root issues related to multi-root support labels Jul 13, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I confirmed that:

  • adding/removing roots properly updates the debug configurations
  • given the selected configuration, open configuration properly opens the launch.json of the appropriate root

@vince-fugnitto vince-fugnitto merged commit 84fe3d9 into eclipse-theia:master Jul 13, 2023
@vince-fugnitto vince-fugnitto added this to the 1.40.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality multi-root issues related to multi-root support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

When removing a folder from the workspace, the associated launch config still shows up in the debug widgets
2 participants