Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: support editor/title/run predefined entry #12637

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

rschnekenbu
Copy link
Contributor

@rschnekenbu rschnekenbu commented Jun 21, 2023

What it does

Adds a missing predefined entry in the menus
This enables the possibility to contribute menus to editor/title/run entry as defined in vscode.

Fixes #9387

Contributed on behalf of ST Microelectronics

How to test

  1. Install following extension:
  1. Try to open a menu on any file except md file, one menu should be contributed by the extension. A second one will pop-up on any md file if the basic markdown extension is installed.
    before-addeMenu

  2. Update your theia repository to use this PR

  3. Any file should now also have an additional run menu entry, and the md files shall display a total of 2 o 4 menus with this extension depending if markdown extension is installed or not.
    after-addeMenu

Review checklist

Reminder for reviewers

Closes: eclipse-theia#9387

The commit adds  the "editor/title/run" contribution point to menus

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
@rschnekenbu rschnekenbu marked this pull request as ready for review June 22, 2023 10:27
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Jun 22, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the new menu works as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support "editor/title/run" toolbar commands
4 participants