Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #12605: Edits made to watch expressions are not immediately shown when there is no debug session #12627

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

sophiali23
Copy link
Contributor

@sophiali23 sophiali23 commented Jun 16, 2023

What it does

Fixes #12605. When no debug session is active and user edits a watch expression, the updated expression is not shown until Debug view is reopened or user clicks on the expression.

In the current code, the watch expression change event is not fired when there is no debug session, so I updated the logic to trigger it regardless of whether or not there is a debug session.

How to test

  1. Make sure you don't have a debug session running.
  2. Add a watch expression.
  3. Edit that watch expression.
  4. Make sure that the updated expression is now shown. It should have replaced the old expression.

Review checklist

Reminder for reviewers

…hether or not there is a debug session active so the updated expression can always be shown in UI. Fixes issue eclipse-theia#12605

Signed-off-by: Sophia Li <[email protected]>
@vince-fugnitto vince-fugnitto added the debug issues that related to debug functionality label Jun 19, 2023
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sophiali23 thank you for your first contribution!

Unfortunately, the changes don't seem to fix the issue at hand, see the following:

2023-06-27.00-00-53.mp4

@sophiali23
Copy link
Contributor Author

Hey @sophiali23 thank you for your first contribution!

Unfortunately, the changes don't seem to fix the issue at hand, see the following:

2023-06-27.00-00-53.mp4

Hi @msujew, this is a separate issue. The fix I implemented is in the watch panel:

2023-07-19_10h12_57.mp4

@sophiali23 sophiali23 requested a review from msujew July 19, 2023 14:20
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks! I should stop reviewing code after midnight...

The changes look good to me. I can confirm that the issue exists on master and are fixed by this patch.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 👍

@vince-fugnitto vince-fugnitto merged commit dc8b08c into eclipse-theia:master Aug 31, 2023
@vince-fugnitto vince-fugnitto added this to the 1.41.0 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

When a debug session is not active, edits made to watch expressions are not immediately shown
4 participants