Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Stub onWillSaveNotebookDocument (1.78 new API) #12614

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

rschnekenbu
Copy link
Contributor

What it does

Stub vscode 'Notebook' onWillSaveNotebookDocument & NotebookDocumentWillSaveEvent API
This enables the possibility to load and start plugins which depend on the new 1.78 'Notebook' API on workspace.

Fixes #12529

Contributed on behalf of ST Microelectronics

How to test

  1. Install following extension:
  1. Reproduce the problem in the theia instance before switching to this PR. When starting theia with the extension installed, an error will pop-up telling that Activating extension 'notebook-onwillsave-extension' failed: o.workspace.onWillSaveNotebookDocument is not a function
  2. Update your theia repository to use this PR
  3. Open the same workspace and make sure the message above is no longer displayed. Nothing should happen, as the API is only stubbed, not implemented.

Review checklist

Reminder for reviewers

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility notebook issues related to notebooks labels Jun 12, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JonasHelming JonasHelming merged commit 0660fb0 into eclipse-theia:master Jun 13, 2023
@vince-fugnitto vince-fugnitto added this to the 1.39.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] Support NotebookDocumentWillSaveEvent
3 participants