Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12570 Localized quick file open labels #12571

Merged
merged 2 commits into from
May 30, 2023

Conversation

Zebsterpasha
Copy link
Contributor

What it does

Fixes #12570
Localized labels "recently opened" "file results"

How to test

Just check the keys of licalized strings

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label May 26, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I confirmed it is properly localized.

Comment on lines +171 to +174
recentlyUsedItems.push({
type: 'separator',
label: nls.localizeByDefault('recently opened')
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: splitting the lines are unnecessary

Suggested change
recentlyUsedItems.push({
type: 'separator',
label: nls.localizeByDefault('recently opened')
});
recentlyUsedItems.push({ type: 'separator', label: nls.localizeByDefault('recently opened') });

The same is true below.

@vince-fugnitto vince-fugnitto merged commit e9cd687 into eclipse-theia:master May 30, 2023
@vince-fugnitto vince-fugnitto added this to the 1.39.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Quick file open labels are not localized
2 participants