-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin: re-organize proposed
api files
#12550
Conversation
85111c2
to
7112f4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the distribution of code to the different new files,
I found all code previously hosted in the former theia-proposed.d.ts
file
mapped to the new files. 👍
The additions and modifications look good to me !
Testing was limited to start theia
validate that no new activation failures arise,
and test some basic functionality.
@rschnekenbu FYI |
7112f4f
to
77c4b9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as @alvsan09, I did a quick test running theia
and having no additional issues.
I have minor comments on textSearchQuery.d.ts and findTextInFile.d.ts proposals, which have duplicate code.
Otherwise, that looks very good to me and it's a great way to improve proposed APIs support!
Signed-off-by: vince-fugnitto <[email protected]>
77c4b9a
to
ff01cc5
Compare
@rschnekenbu thank you for the feedback, I updated the pull-request accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vince-fugnitto, that looks good to me!
What it does
The pull-request re-organizes our
theia-proposed.d.ts
to follow the same conventions present in vscode, and also make it easier to update or add proposed apis in the future.The changes:
theia-extra.d.ts
properlyHow to test
Review checklist
Reminder for reviewers