Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update debug createFrameDecorations bug when debug thread is not … #12543

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

noneghost
Copy link
Contributor

@noneghost noneghost commented May 18, 2023

What it does

Closes: #12540.

The pull-request fixes an issue where an unknown breakpoint is triggered.

How to test

  1. follow the steps to reproduce from Python debug: An unexpected breakpoint is triggered in the editor view when no breakpoint is set #12540.

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noneghost thank you for the contribution, and sorry for the delay in the review.
Can you clarify as to why the bug was happening, and why these changes are needed?

@noneghost
Copy link
Contributor Author

@noneghost thank you for the contribution, and sorry for the delay in the review. Can you clarify as to why the bug was happening, and why these changes are needed?

when program is running state, the thread is not stopped, shouldn't createFrameDecorations.

1 similar comment
@noneghost
Copy link
Contributor Author

@noneghost thank you for the contribution, and sorry for the delay in the review. Can you clarify as to why the bug was happening, and why these changes are needed?

when program is running state, the thread is not stopped, shouldn't createFrameDecorations.

Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Call stack" and "Variables" views still get populated upon thread start (which is odd, IMO), but the PR is an improvement over the current state, which lgtm.

@tsmaeder tsmaeder merged commit 4b8ec2d into eclipse-theia:master Feb 12, 2024
@jfaltermeier jfaltermeier added this to the 1.47.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Python debug: An unexpected breakpoint is triggered in the editor view when no breakpoint is set
4 participants