Associate root folder to dynamic debug configurations #12482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvsan09
added
vscode
alvsan09
force-pushed
the
asl/fixing_dynamic_debug
branch
from
a04182b
to
f9112ae
Compare
alvsan09
force-pushed
the
asl/fixing_dynamic_debug
branch
from
f9112ae
to
31a99fb
Compare
|
The updated commit |
alvsan09
force-pushed
the
asl/fixing_dynamic_debug
branch
from
31a99fb
to
26b2a6c
Compare
The methods is the `vscode` interface `DebugConfigurationProvider` specify the parameter `folder: WorksapceFolder | undefined'. The parameter can be `undefined` in the context of a folderless setup however some plugins expect it to be present always (e.g. ms-python.python). The original implementation of dynamic debug configurations did not provide this parameter. This change associates the root folder to the contributed configurations directly after the response for the call to 'provideDebugConfigurations' and it makes sure to preserve this parameter within the pick items presented to the user. Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09
force-pushed
the
asl/fixing_dynamic_debug
branch
from
26b2a6c
to
aad3b80
Compare
|
The latest commit, is just squashing of the two related commits |
vince-fugnitto
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #12352
The methods in the
vscodeinterfaceDebugConfigurationProviderspecify the parameter `folder: WorksapceFolder | undefined'.The parameter can be
undefinedin the context of afolderlesssetup, however some plugins expect it to be present always (e.g. ms-python.python). The original implementation of dynamic debug configurations did not provide this parameter.This change associates the root folder to the contributed configurations directly after the response for the call to 'provideDebugConfigurations' and it makes sure to preserve this parameter within the pick items presented to the user.
With the above, dynamic configurations are able to execute programs located inside the same root.
How to test
ms-python.pythongets loaded and activatedtheia'sExtensionsview search forpythonand install the extension with idms-python.pythonpythonprogram as shown below:https://user-images.githubusercontent.com/76971376/236043099-5a3e0b1d-1425-4b06-a3b6-bc4754980dcf.mp4
hello-multi-root-js.zip
zipfile above and usingtheiaopen the multi root workspace file included in the main folderrootfolders namedoriginalandcopy, each root have its ownsrcfolder withjsfiles ready to runhttps://user-images.githubusercontent.com/76971376/236050594-6a7f0907-6e52-40ef-a3ee-83ded4ecad80.mp4
quick access(e.g., typing?from command palette), Verify the successful execution of programs via extension provided dynamic debug configurations (follow the video clip below),https://user-images.githubusercontent.com/76971376/236050617-59f796d5-eabf-4a9f-a01b-d31a07cec58c.mp4
Review checklist
Reminder for reviewers