Implement "secondary window" support for Electron #12481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmaeder
force-pushed
the
11642_electron_secondary_win
branch
from
b13d1d0
to
f49a489
Compare
tsmaeder
changed the title
vince-fugnitto
added
electron
msujew
reviewed
May 24, 2023
tsmaeder
force-pushed
the
11642_electron_secondary_win
branch
from
18d251d
to
6652d22
Compare
msujew
approved these changes
Jun 1, 2023
Fixes eclipse-theia#11642 The main change is to prevent the secondary window from closing until the extracted widget is removed from the window. This includes waiting until any close handling (including dialogs) are finished. To enable this properly, dialog support has been extended to work with secondary windows, including support for the StylingService in secondary windows. Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
force-pushed
the
11642_electron_secondary_win
branch
from
6652d22
to
8f9acf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11642
The main change is to prevent the secondary window from closing until the extracted widget is removed from the window. This includes waiting until any close handling (including dialogs) are finished.
To enable this properly, dialog support has been extended to work with secondary windows, including support for the StylingService in secondary windows.
Contributed on behalf of STMicroelectronics
How to test
The test scenarios from #11048 apply, but run them in electron
Review checklist
Reminder for reviewers