monaco: parseSnippet RangeError handling #12463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernandoAscencio
force-pushed
the
fa/parseSnippedRangeError
branch
from
a9bf26a to
a6a9825
Compare
vince-fugnitto
added
monaco
Closes 12434 -Changes `parseSnippets` from recursive function to nested for-loops. -Eliminates 'prefix' requirement for `JsonSerializedSnippet.is()`. -Changes handling to account for missing 'prefix' parameter. -Add `isFileTemplate` param to Snippet to bring it in line with VSCode Signed-Off-By: FernandoAscencio <[email protected]>
Co-authored-by: Paul Maréchal <[email protected]>
vince-fugnitto
force-pushed
the
fa/parseSnippedRangeError
branch
from
ce1f830 to
c89ff7c
Compare
paul-marechal
approved these changes
Apr 27, 2023
jonah-iden
pushed a commit
to jonah-iden/theia
that referenced
this pull request
May 2, 2023
Change `parseSnippets` from recursive function to nested for-loops. Eliminate 'prefix' requirement for `JsonSerializedSnippet.is()`. Change handling to account for missing 'prefix' parameter. Add `isFileTemplate` param to Snippet to bring it in line with VS Code. Signed-off-by: FernandoAscencio <[email protected]>
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12434
parseSnippetsfrom recursive function to nested for-loops.JsonSerializedSnippet.is()as it is in VS Code.isFileTemplateparam to Snippet to bring it in line with VSCode.Notes
As discussed here there are three parameters in VS Code
Snippetthat are not present in Theia's:snippetSource,snippetIdentifier, andextensionId. Their inclusion or exclusion seems to be out of this PR's scope.When adding a prefix to the error causing snippet as seen here it does not follow VS Code's display as seen here.
How to test
Follow the steps in #12434.
Review checklist
Reminder for reviewers