Notifications: Toaster Container did not close when empty #12457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds: - Condition so that the toaster container will close when empty. This was an issue when testing 12446. When seemingly it needed two `esc` Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This commit adds:
This can be tested when running the
Quick Input: Hello Worldcommand after extracting the quickpickesctest-0.0.2.zipWhen, after closing the toaster notifications and focusing in the inputbox, pressing
esconce does not close the inputbox.How to test
xbuttonesconceBefore
After
Review checklist
Reminder for reviewers