Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Indent decoration blocked pointer events #12436

Conversation

FernandoAscencio
Copy link
Contributor

What it does

This commit fixes a small issue where the indent decoration blocked right and left clicks.

Before:
IndentIssue

After:
IndentIssueFixed

How to test

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience labels Apr 20, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and works well 👍

This commit fixes a small issue where the indent decoration blocked
right and left clicks. Thus reducing the effective area of selection.

Signed-Off-By: FernandoAscencio <[email protected]>
@vince-fugnitto vince-fugnitto merged commit 1a2d07a into eclipse-theia:master Apr 27, 2023
@vince-fugnitto vince-fugnitto deleted the fa/TreeIndentPointerEventIssue branch April 27, 2023 18:21
@vince-fugnitto vince-fugnitto added this to the 1.37.0 milestone Apr 27, 2023
jonah-iden pushed a commit to jonah-iden/theia that referenced this pull request May 2, 2023
This commit fixes a small issue where the indent decoration blocked
right and left clicks. Thus reducing the effective area of selection.

Signed-off-by: FernandoAscencio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants