-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style: Indent decoration blocked pointer events #12436
Merged
vince-fugnitto
merged 1 commit into
eclipse-theia:master
from
FernandoAscencio:fa/TreeIndentPointerEventIssue
Apr 27, 2023
Merged
Style: Indent decoration blocked pointer events #12436
vince-fugnitto
merged 1 commit into
eclipse-theia:master
from
FernandoAscencio:fa/TreeIndentPointerEventIssue
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
tree
issues related to the tree (ex: tree widget)
ui/ux
issues related to user interface / user experience
labels
Apr 20, 2023
vince-fugnitto
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch and works well 👍
This commit fixes a small issue where the indent decoration blocked right and left clicks. Thus reducing the effective area of selection. Signed-Off-By: FernandoAscencio <[email protected]>
vince-fugnitto
force-pushed
the
fa/TreeIndentPointerEventIssue
branch
from
April 27, 2023 17:48
ff90560
to
3ba6f1e
Compare
jonah-iden
pushed a commit
to jonah-iden/theia
that referenced
this pull request
May 2, 2023
This commit fixes a small issue where the indent decoration blocked right and left clicks. Thus reducing the effective area of selection. Signed-off-by: FernandoAscencio <[email protected]>
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This commit fixes a small issue where the indent decoration blocked right and left clicks.
Before:
After:
How to test
Review checklist
Reminder for reviewers