Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled promise rejection during git operations #12433

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Fix unhandled promise rejection during git operations #12433

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
681fc11
add catch method to handle promise rejection when exception thrown fr…
erezmus Apr 19, 2023
e171950
Merge branch 'master' into fix-potential-crash-during-git-operations
erezmus Aug 30, 2023
3f14bce
only catch sync errors
erezmus Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/git/src/node/git-repository-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class GitRepositoryManager {

run<T>(repository: Repository, op: () => Promise<T>): Promise<T> {
const result = op();
result.then(() => this.sync(repository));
result.then(() => this.sync(repository)).catch(e => console.log(e));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the sync is actually unhandled, whereas the op() call is handled at a higher level. If we use a catch-all mechanism here, we potentially swallow errors that should be thrown and caught on the caller site. We should only call catch on the sync promise:

Suggested change
result.then(() => this.sync(repository)).catch(e => console.log(e));
result.then(() => this.sync(repository).catch(e => console.log(e)));

return result;
}

Expand Down