monaco-quick-input-service: set context key "inQuickOpen" #12427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernandoAscencio
changed the title
Context Key "inQuickOpen" exists in vscode and its value (true or false) reflects whether the Quick Open, AKA Quick input, is currently open/visible or not. This context key can be useful in Theia too, e.g. it can be used in the "when" clause of commands registered by vscode extensions, or programmatically whenever it's useful to know the state of the Quick Open UI. Signed-off-by: Marc Dumais <[email protected]> Co-authored-by: FernandoAscencio <[email protected]>
Signed-off-by: Marc Dumais <[email protected]>
FernandoAscencio
force-pushed
the
fa/inQuickOpen_contextKey
branch
from
9a4d263 to
346cab1
Compare
vince-fugnitto
approved these changes
Apr 17, 2023
1 task
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Continues #12377
Applies the changes suggested in the comments by Vince
How to test
Uses the provided test in the browser suite. Confirm that CI passes.
Review checklist
Reminder for reviewers