Fix SCM Inline commands #12295
Merged
Fix SCM Inline commands #12295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
vscode
|
As @vince-fugnitto mentioned, the commit message accept button on the COMMIT_EDITMSG editor/title tab bar is broken since commit 81b98d6. Any objections to merge this PR? |
SCM inline commands were executed before adapting their arguments to its 'rpc' format, causing an infinite loop while trying to serialize argument objects before sending them to the 'rpc' channel. The adapter's exist and were originally used by context menus. This update uses the 'MenuCommandExecutor' to channel the execution of SCM inline commands through the existing registered adapters. It also replaces the use of 'CommandRegistry' by 'MenuCommandExecutor' Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09
force-pushed
the
asl/fix_scm_inline_commands
branch
from
d07c072
to
ecb7d3b
Compare
vince-fugnitto
approved these changes
Mar 17, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #12173
Fixes: #12238
SCM inline commands were executed before adapting their arguments to its 'rpc' format.
This caused an infinite loop while trying to package and serialize argument objects before sending them to the 'rpc' channel.
The adapters exist and were originally used by context menus.
This update uses the 'MenuCommandExecutor' to channel the execution of SCM inline commands through the existing registered adapters.
How to test
Inspired by #12173
@theia/gitin either thebrowserorelectron's package.jsonyarn download:pluginspulls the builtins https://github.com/eclipse-theia/theia/blob/v1.35.0/package.json#L113-L114scmview with the inline toolbar item for the changesscm_inline_commands.mp4.mp4
Review checklist
Reminder for reviewers