Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickInput: Error Message on File not Found #12255

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

FernandoAscencio
Copy link
Contributor

What it does

Fixes an issue where the error message did not appear when file not found.

How to test

  1. Create a test file on Theia
  2. Open the file
  3. Delete the file and close the viewer
  4. Open the Quick Input menu on recent files
  5. Open the deleted file

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the file search issues related to the file search label Mar 2, 2023
Fixes an issue where the error message did not render when file not found.

Signed-Off-By: FernandoAscencio <[email protected]>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 I can confirm that the message is now displayed.

@tsmaeder tsmaeder merged commit 99b8648 into eclipse-theia:master Mar 30, 2023
@vince-fugnitto vince-fugnitto deleted the fa/QuickInputErrorMsg branch March 30, 2023 11:27
@vince-fugnitto vince-fugnitto added this to the 1.36.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file search issues related to the file search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants