Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Dialog style streamline #12254

Merged

Conversation

FernandoAscencio
Copy link
Contributor

What it does

This commit eliminates Dialog extra space upon opening.

How to test

Open a dialog box in Theia and check that it displays properly.

Review checklist

Reminder for reviewers

This commit eliminates Dialog extra space upon opening.

Signed-Off-By: FernandoAscencio <[email protected]>
@vince-fugnitto vince-fugnitto added dialogs issues related to dialogs ui/ux issues related to user interface / user experience labels Mar 2, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me when I tested multiple dialogs 👍

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me 👍

@vince-fugnitto vince-fugnitto merged commit 9fd7735 into eclipse-theia:master Mar 8, 2023
@vince-fugnitto vince-fugnitto deleted the fa/DialogStyleChanges branch March 8, 2023 13:48
@vince-fugnitto vince-fugnitto added this to the 1.36.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialogs issues related to dialogs ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants