Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align border-radius with vscode #12252

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Align border-radius with vscode #12252

merged 2 commits into from
Jun 28, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Mar 2, 2023

What it does

VSCode has recently updated a lot of their UI to use border radius' (menus, menu bars, notifications, buttons, text boxes, quick input etc.). This change aligns Theia to this design decision.

How to test

Assert that the changed elements align with vscode in regards to their border design.

Review checklist

Reminder for reviewers

@msujew msujew added the ui/ux issues related to user interface / user experience label Mar 2, 2023
@msujew msujew force-pushed the msujew/border-radius branch from 91b9046 to c4c4ab3 Compare April 14, 2023 22:13
@msujew msujew requested a review from vince-fugnitto June 19, 2023 09:06
@msujew msujew force-pushed the msujew/border-radius branch from c4c4ab3 to f69b799 Compare June 19, 2023 09:13
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good to me, I noticed two missing areas when testing:

  • the AlertMessage are not rounded (ex: when no workspace is present and we check the scm view)
  • the theia-select (select input) are not rounded

@msujew
Copy link
Member Author

msujew commented Jun 23, 2023

Thanks Vince for looking it. I've adjusted those two (actually three see ebbbdc2) points.

@msujew msujew requested a review from vince-fugnitto June 27, 2023 15:38
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
The rounded borders in the quick-open menus will likely be contributed by newer monaco versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants