Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Breakpoint Decoration Rendering #12249

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Mar 1, 2023

What it does

Fixes another part of #11878 by setting decorations on the editor class rather than editor model class. In the latter case, all decorations were shared by all editors referring to the model. With this code, each editor owns a different set of decorations that refer to common state, where appropriate.

How to test

  1. Follow instructions from Fire breakpoint events only if breakpoint metadata changes #12183.
  2. Hover over the breakpoint gutter for one of the split editors, but don't add a breakpoint
  3. You should see a lighter / less opaque breakpoint marking, but only in the editor whose gutter you're hovering over.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the debug issues that related to debug functionality label Mar 1, 2023
@colin-grant-work colin-grant-work force-pushed the bugfix/breakpoint-decoration-ownership branch from 5171af4 to ab8726f Compare March 1, 2023 22:42
@colin-grant-work colin-grant-work force-pushed the bugfix/breakpoint-decoration-ownership branch from ab8726f to 32b0483 Compare March 1, 2023 22:45
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work as expected 👍 Setting breakpoints, and debugging still works.

@colin-grant-work colin-grant-work merged commit 7c2c94c into eclipse-theia:master Mar 3, 2023
@colin-grant-work colin-grant-work deleted the bugfix/breakpoint-decoration-ownership branch March 3, 2023 16:35
@colin-grant-work colin-grant-work added this to the 1.36.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants