Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DebugWidget properly reports change in trackable widgets #12241

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

martin-fleck-at
Copy link
Contributor

What it does

Necessary because the debug session widgets are created lazily after the layout has been initialized.

Fixes #12240

How to test

  1. Add watch expression in the 'Watch' section of the Debug widget.
  2. Context menu should work
  3. Reset Workbench Layout > context menu should work
  4. Reload Window > context menu should work

issue-debug-layout-fix

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the debug issues that related to debug functionality label Feb 28, 2023
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and confirmed the context menu survives the layout reset.

Necessary because the debug session widgets are created lazily after
the layout has been initialized.

Fixes #12240
@martin-fleck-at martin-fleck-at merged commit 0e0e9ee into master Apr 21, 2023
@martin-fleck-at martin-fleck-at deleted the issues/12240 branch April 21, 2023 09:09
@github-actions github-actions bot added this to the 1.37.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Context menu not showing up on debug widgets when resetting layout
3 participants