-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure DebugWidget properly reports change in trackable widgets #12241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-fleck-at
force-pushed
the
issues/12240
branch
from
March 1, 2023 08:42
b5b8ae3
to
a2f76d2
Compare
tsmaeder
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and confirmed the context menu survives the layout reset.
martin-fleck-at
force-pushed
the
issues/12240
branch
from
April 21, 2023 08:18
a2f76d2
to
b65dd1e
Compare
Necessary because the debug session widgets are created lazily after the layout has been initialized. Fixes #12240
martin-fleck-at
force-pushed
the
issues/12240
branch
from
April 21, 2023 08:33
b65dd1e
to
24c8eaf
Compare
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Necessary because the debug session widgets are created lazily after the layout has been initialized.
Fixes #12240
How to test
Review checklist
Reminder for reviewers