-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boolean suppression DebugSessionOptions #12220
Add boolean suppression DebugSessionOptions #12220
Conversation
Add options to suppress the debugging statusbar, toolbar and view. As well as the saving before starting a debugging session. Fixes eclipse-theia#12015 Contributed on behalf of STMicroelectronics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions/suggestions
packages/debug/src/browser/debug-frontend-application-contribution.ts
Outdated
Show resolved
Hide resolved
packages/debug/src/browser/debug-frontend-application-contribution.ts
Outdated
Show resolved
Hide resolved
There does not seem to be an option in the settings UI for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the changes, but we need to decide whether the support for the saveOnStart
preference should be in this PR or not. If not, could you please open an issue so we can track the problem?
I created #12319 for the follow up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
What it does
Add options to suppress the debugging statusbar, toolbar and view.
As well as the saving before starting a debugging session.
Fixes #12015
Contributed on behalf of STMicroelectronics
Note:
Parent/child sessions are currently handled as followed:
I mostly went with two different approaches here due to the significance of the actions (saving vs graphical-only), but your input is welcome and i will gladly unify the approaches, when the "better" solution is identified.
How to test
It registers a few commands that start the "Launch Browser Backend" debug config with different options set.
Start Debugging
commands. It says in parenthesis which options are enabled.Review checklist
Reminder for reviewers