[browser tests] [typescript] disable files.refactoring.autoSave #12209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
force-pushed
the
fix-browser-tests2
branch
from
3a572ff
to
a33278e
Compare
Also solidify "Can execute code actions" test Preference "files.refactoring.autoSave" is new and enabled by default. It introduced entropy in the typescript test suite that was not there before. Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
fix-browser-tests2
branch
from
a33278e
to
14e0acb
Compare
marcdumais-work
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Follow-up to #12117. Attempt to fix a new failure: https://github.com/eclipse-theia/theia/actions/runs/4244786034/jobs/7379398368
How to test
The browser tests should pass!
To run locally: yarn browser test
Run with UI: yarn browser test:debug
Review checklist
Reminder for reviewers