Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus first button in modal notification #12204

Closed
wants to merge 1 commit into from
Closed

Focus first button in modal notification #12204

wants to merge 1 commit into from

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 22, 2023

What it does

Closes #12203

How to test

Repeat the reproduction steps from #12203 and assert that the modal behaves as in VSCode.

Review checklist

Reminder for reviewers

@msujew msujew added dialogs issues related to dialogs vscode issues related to VSCode compatibility labels Feb 22, 2023
@msujew msujew mentioned this pull request Feb 22, 2023
Merged
1 task
@msujew msujew deleted the msujew/focus-modal-notification branch February 22, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dialogs issues related to dialogs vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VSCode] Modal Information Message doesn't take focus on the first button
1 participant
@msujew