Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab API stub and indentation #12201

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Fix tab API stub and indentation #12201

merged 2 commits into from
Feb 21, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 21, 2023

What it does

A follow up on #12051 and #12109. The tab identation was accidentally reverted and there was a @stubbed tag which was left in the code.

How to test

  1. Run the vscode-theia-comparator on the theia.d.ts and confirm that close is no longer stubbed.

Review checklist

Reminder for reviewers

@msujew msujew added the vscode issues related to VSCode compatibility label Feb 21, 2023
@msujew msujew changed the title Msujew/tab api sub Fix tab API stub and indentation Feb 21, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants