Improve transition to/from "offline" state #12196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenneth-marut-work
changed the title
| @@ -90,6 +91,7 @@ export class MonacoEditorModel implements IResolvedTextEditorModel, TextEditorDo | |||
| protected readonly resource: Resource, | |||
| protected readonly m2p: MonacoToProtocolConverter, | |||
| protected readonly p2m: ProtocolToMonacoConverter, | |||
| protected readonly connectionStatusService: ConnectionStatusService, | |||
There was a problem hiding this comment.
This should get a 'breaking changes' mention.
Comment on lines
+110
to
+113
| this.toDispose.push(this.connectionStatusService.onStatusChange(() => { | ||
| this.cancelSave(); | ||
| this.cancelSync(); | ||
| })); |
There was a problem hiding this comment.
The this is where the problem manifested itself, but I wonder if the the problem shouldn't be fixed in the FileResource code, since that's where the saving happens, and it's the connection to the backend file system that breaks saving / loading new content?
|
I believe we can close the pull-request for the time being, and revisit as necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #12194 by adding a timeout to
ConnectionStatusService'spingservice to make sure frontend is aware of network interruptions sooner if backend is hanging.Fixes #12195 by cancelling save/sync in
monaco-editor-modelwhenConnectionStatusService'sonStatusChangedevent fires preventing scheduled saves/syncs from never resolving when backend goes offlineThe
hang-backendpackage and command will be removed before merging this PR.Breaking Changes
Modifies constructor args for
MonacoEditorModelto pass inConnectionStatusServiceHow to test
To test #12194:
To test #12195:
Review checklist
Reminder for reviewers