outline: add 'expand-all' toolbar item #12188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Looks good to me 👍 I can confirm that the toolbar entry works just like in VSCode:
- As long as any node is expanded the toolbar offers to collapse the outline
- When all nodes are collapsed, it offers to expand all nodes
- Expanding and collapsing manually updates the toolbar command as expected
|
@paul-marechal anything we're waiting for on this one? |
The commit adds support for the `expand-all` toolbar item for the `outline-view` in order to expand rendered nodes. The changes mean that the toolbar item for `collapse-all` and `expand-all` will be toggleable based on the state of the view. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/outline-expand-all
branch
from
9150ff4 to
d167824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request adds support for the
expand-alltoolbar item for theoutline-viewin order to expand rendered nodes. The changes mean that the toolbar item forcollapse-allandexpand-allwill be toggleable based on the state of the view.How to test
Review checklist
Reminder for reviewers