Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: update builtins to 1.64.2, 1.66.2 #12094

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request updates the repository's builtins to their latest version (1.64.2).
Note: work to publish and use 1.68.1 is still underway.

How to test

  • Confirm that CI passes

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added the builtins Issues related to VS Code builtin extensions label Jan 20, 2023
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vince!

vince-fugnitto and others added 3 commits January 26, 2023 10:25
The commit updates the builtins used by the framework to `1.64.2`
(currently latest).

Signed-off-by: vince-fugnitto <[email protected]>
Newer published version that will be picked-up now that we support newer API uses a
proposed API that we do not yet have, which prevents the extension from activating:

onWillDropOnTextEditor()

Signed-off-by: Marc Dumais <[email protected]>
Use the newly published extension pack for the latest vscode extensions API
we support, v1.66.2. Add vscode.ipynb to exclusion list since it does not
work well yet.

Signed-off-by: Marc Dumais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants