Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "enabled" field to SourceControlInputBox for vscode api. #12069

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Jan 13, 2023

Signed-off-by: Jonah Iden [email protected]

What it does

closes #12027

Adds the enabled field to SourceControlInputBox according to the vs code api

also added some semicolons where they were missing

How to test

small extension for testing:

steps for testing

  1. remove "@Theia/git" from examples/{browser or election}/package.json
  2. build and start theia (browser or electron)
  3. download or build and install vsix extension
  4. execute command "Test change SourceControlInputBox status"
  5. see new provider is registered and inputBox should be disabled (since executing the command changes the enabled status from default value true to false)
  6. execute command again and see input box is enabled again

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility scm issues related to the source control manager labels Jan 13, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I confirmed that the enabled field is properly supported.


@jonah-iden in case you weren't aware we can auto-close issues (on merge) if we use the proper keywords in the pull-request description. I updated the description so that it is automatically linked, but it looks like you modified it again afterwards.

@jonah-iden
Copy link
Contributor Author

thanks for the heads-up about the keywords. Didn't knew about that. I will keep that in mind for future PRs.
Also since i don't have write access rights yet i'm not able to merge PRs, so someone else needs to do that

@vince-fugnitto vince-fugnitto merged commit aca9a26 into eclipse-theia:master Jan 16, 2023
@paul-marechal paul-marechal added this to the 1.34.0 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] Support property enabled in SourceControlInputBox
3 participants