-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught error handler made easily overridable #12068
Merged
paul-marechal
merged 1 commit into
eclipse-theia:master
from
federicobozzini:overridable-uncaught-error-handler
Jan 13, 2023
Merged
Uncaught error handler made easily overridable #12068
paul-marechal
merged 1 commit into
eclipse-theia:master
from
federicobozzini:overridable-uncaught-error-handler
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Bozzini <[email protected]>
vince-fugnitto
added
the
extensibility
issues to simplify ability to extend Theia
label
Jan 13, 2023
vince-fugnitto
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
federicobozzini
added a commit
to ARMmbed/theia
that referenced
this pull request
Jan 13, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
CareyJWilliams
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Feb 3, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
arekzaluski
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Feb 14, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Mar 20, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
federicobozzini
added a commit
to ARMmbed/theia
that referenced
this pull request
Apr 25, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
May 11, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
CareyJWilliams
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Jun 22, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
CareyJWilliams
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Jun 23, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Aug 2, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Sep 12, 2023
…2068) Signed-off-by: Federico Bozzini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR make the generic error for an uncaught exception more easily overridable.
How to test
It's possible to test this PR by creating a subclass of
BackendApplication
overriding thehandleUncaughtError
method.Review checklist
Reminder for reviewers