Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught error handler made easily overridable #12068

Conversation

federicobozzini
Copy link
Contributor

What it does

This PR make the generic error for an uncaught exception more easily overridable.

How to test

It's possible to test this PR by creating a subclass of BackendApplication overriding the handleUncaughtError method.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the extensibility issues to simplify ability to extend Theia label Jan 13, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paul-marechal paul-marechal merged commit 7176208 into eclipse-theia:master Jan 13, 2023
federicobozzini added a commit to ARMmbed/theia that referenced this pull request Jan 13, 2023
@paul-marechal paul-marechal added this to the 1.34.0 milestone Jan 24, 2023
CareyJWilliams pushed a commit to ARMmbed/theia that referenced this pull request Feb 3, 2023
arekzaluski pushed a commit to ARMmbed/theia that referenced this pull request Feb 14, 2023
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Mar 20, 2023
federicobozzini added a commit to ARMmbed/theia that referenced this pull request Apr 25, 2023
erezmus pushed a commit to ARMmbed/theia that referenced this pull request May 11, 2023
CareyJWilliams pushed a commit to ARMmbed/theia that referenced this pull request Jun 22, 2023
CareyJWilliams pushed a commit to ARMmbed/theia that referenced this pull request Jun 23, 2023
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Aug 2, 2023
erezmus pushed a commit to ARMmbed/theia that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility issues to simplify ability to extend Theia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants