packages: title localization fix #12062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernandoAscencio
force-pushed
the
fa/dialogueTitleLocalization
branch
from
aa0623e
to
413a2d6
Compare
vince-fugnitto
added
the
localization
The commit fixes six localization bugs related titles of windows and messages. Signed-off-by: FernandoAscencio <[email protected]>
FernandoAscencio
force-pushed
the
fa/dialogueTitleLocalization
branch
from
413a2d6
to
59892d5
Compare
Corrections to the previous localization title fix as suggested in the Reviews Signed-off-by: FernandoAscencio <[email protected]>
Another review correction Signed-off-by: FernandoAscencio <[email protected]>
vince-fugnitto
approved these changes
Jan 12, 2023
Co-authored-by: Vincent Fugnitto <[email protected]>
The commit fixes six localization bugs related titles of windows and messages. Signed-off-by: FernandoAscencio <[email protected]>
…nandoAscencio/theia into fa/dialogueTitleLocalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11954 (comment).
The commit fixes localization bugs found in the titles of windows.
While in the process of solving this issue, a check on other title variables found several other windows with similar localization issues. In total six issues should be fixed.
How to test
To test if the initial issue was solved:
view>debug)watchsection clickadd expression(+ icon)edit watch expressionconfigure display language(usingF1) and install a new languageReview checklist
Reminder for reviewers
Signed-off-by: FernandoAscencio [email protected]