Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed debug hover widget overflowing when content tree is too big #12058

Conversation

jonah-iden
Copy link
Contributor

Signed-off-by: Jonah Iden [email protected]

What it does

fixes #11297

This fixes the overflowing of the DebugHoverWidget when the content tree gets too large.
The problem was, that by default monaco overwrites the display css property of the domNode (contentWidget#setPosition) to display: block instead of the given display: flex. with the !important it stays as flex as intended.

How to test

  1. create a breakpoint and start a debug session
    a. (i used the Run Mocha Tests target and made a breakpoint in frontend-application-config-provider.spec.ts)
  2. hover over a variable and see the debug hover widget appear
  3. expand the tree nodes so that the tree gets bigger than the widget
  4. see it doews not overflow scrolling should now be possible

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added debug issues that related to debug functionality monaco issues related to monaco labels Jan 11, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me:

  • the display is correct when the content overflows
  • scrolling the hover does not affect the editor

@paul-marechal paul-marechal merged commit 255450b into eclipse-theia:master Jan 16, 2023
@paul-marechal paul-marechal added this to the 1.34.0 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality monaco issues related to monaco
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug hover widget extends beyond bounds
3 participants