Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle top-level preference access from plugins #12056

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Jan 10, 2023

What it does

Fixes #12043

How to test

Follow the steps in #12043, but observe that there are no keys that include the string "undefined".

You can use this plugin and the command 'Access preferences at the top level'

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added preferences issues related to preferences vscode issues related to VSCode compatibility labels Jan 10, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

2023-01-10T17:32:29.378Z root INFO [hosted-plugin: 2253741] {
  key: 'editor.tabSize',
  defaultValue: 4,
  globalValue: 8,
  workspaceValue: undefined,
  workspaceFolderValue: undefined
}
2023-01-10T17:32:29.437Z root INFO [hosted-plugin: 2253741] {
  key: 'tabSize',
  defaultValue: 4,
  globalValue: 8,
  workspaceValue: undefined,
  workspaceFolderValue: undefined
}

@colin-grant-work colin-grant-work merged commit c5e48b5 into eclipse-theia:master Jan 11, 2023
@colin-grant-work colin-grant-work deleted the bugfix/top-level-plugin-preference-access branch January 11, 2023 01:18
@colin-grant-work colin-grant-work added this to the 1.34.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorkspaceConfiguration update and inspect methods fail if section is undefined
2 participants