Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file system path for copy commands #12002

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Dec 16, 2022

What it does

Closes #8098

How to test

  1. Open Theia on Windows (either browser or Electron)
  2. Use the Copy Path and Copy Relative Path commands from the context menu of the navigator
  3. Assert that the clipboard contains valid Windows file paths. (e.g. C:\user\file.txt instead of /c:/user/file.txt).

Review checklist

Reminder for reviewers

@msujew msujew added the filesystem issues related to the filesystem label Dec 16, 2022
@vince-fugnitto vince-fugnitto added the OS/Windows issues related to the Windows OS label Jan 11, 2023
@vince-fugnitto
Copy link
Member

@paul-marechal do you mind reviewing given you have a windows machine?

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks

@paul-marechal paul-marechal merged commit 2d08d88 into master Jan 13, 2023
@github-actions github-actions bot added this to the 1.34.0 milestone Jan 13, 2023
@msujew msujew deleted the msujew/copy-file-system-path branch January 15, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem issues related to the filesystem OS/Windows issues related to the Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: 'copy path' returns wrong path for windows
3 participants