Use client side rate limiting for plugin download #11962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Related to #11860. The publicly managed open-vsx instance is using a rate limiting of 15 requests per second (yielding a
429
status code on too many requests). This change introduces a rate limiter that limits the amount of requests that we send per second to 15, while also handling the429
status code a bit better.It also reinstates the parallel-by-default behavior of the plugin download command, which was changed in #11860. Additionally provides a CLI argument to change the rate limit.
How to test
plugins
folder.yarn download:plugins --rate-limit=x
with different values forx
Review checklist
Reminder for reviewers