Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nls: add localizations for preference validation #11906

Merged
merged 1 commit into from
Nov 22, 2022
Merged

nls: add localizations for preference validation #11906

merged 1 commit into from
Nov 22, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request adds localizations for the validation messages of numeric input fields in the preferences-view.

How to test

  1. start the application
  2. open the preferences-view
  3. search for a numeric input field (ex: `fontSize)
  4. input a string - a validation message should appear
  5. use configure display language to switch language
  6. perform the same steps again and confirm the validation message is localized

Review checklist

Reminder for reviewers

@vince-fugnitto
nls: add localizations for preference validation
1fa42c9 
The commit adds the missing localizations for the validation messages
when validating numeric inputs.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added preferences issues related to preferences localization issues related to localization/internalization/nls labels Nov 22, 2022
@vince-fugnitto vince-fugnitto self-assigned this Nov 22, 2022
msujew
msujew approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@vince-fugnitto vince-fugnitto merged commit e4c9144 into master Nov 22, 2022
@vince-fugnitto vince-fugnitto deleted the vf/preference-number-validation branch November 22, 2022 15:30
@github-actions github-actions bot added this to the 1.32.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees

@vince-fugnitto vince-fugnitto

Labels
localization issues related to localization/internalization/nls preferences issues related to preferences
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vince-fugnitto @msujew