Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: fix expansion toggle styling #11895

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

Closes: #11884.

The pull-request fixes the debug expansion toggle styling to align with other views (uses the default styling rather than overriding).

image

image

How to test

  1. start the application using "theia" as a workspace
  2. open a *.spec.ts file and set some breakpoints
  3. start debugging using "run mocha tests"
  4. in the threads view, confirm that the expansion and collapse of items works well

Review checklist

Reminder for reviewers

The commit fixes the expansion toggle styling by removing the overrides
and using the base class styles which are standard for all tree-views.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added debug issues that related to debug functionality ui/ux issues related to user interface / user experience labels Nov 21, 2022
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have manually applied the proposed changes on my branch, and it's working great. Thank you for the prompt fix 💪

Before:

tree_bug.mp4

After:

tree_with_fix.mp4

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well 👍

@vince-fugnitto vince-fugnitto merged commit be60c92 into master Nov 22, 2022
@vince-fugnitto vince-fugnitto deleted the vf/debug-expansion branch November 22, 2022 14:33
@github-actions github-actions bot added this to the 1.32.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tree has styling issues in the threads widget
3 participants