Remove circular dependency check #11864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vince-fugnitto Do you think this warrants an entry in the migration guide? |
@msujew if we can I think it would be good to document, it might not be super clear on how downstream adopters can include their own custom plugins to webpack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
See #11863
Removes circular dependency checking from the generated webpack build. Downstream users still have the option to add the check themselves
How to test
Build the application. No circular dependency warnings should appear. In fact, this should remove all warnings that are left in the webpack build.
Review checklist
Reminder for reviewers