Fix potential race condition when copying files and directories #11857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a missing await to the 'mkdirp' call which fixes a potential race condition in 'doCopy' whereby files are copied into a directory that hasn't been created yet. Signed-off-by: Erez Odier <[email protected]>
msujew
approved these changes
Nov 10, 2022
|
I'm merging this even though the Node 16 CI is failing. I tried poking it again, but also see this has sporadic failures on master. |
federicobozzini
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Apr 17, 2023
…pse-theia#11857) This adds a missing await to the 'mkdirp' call which fixes a potential race condition in 'doCopy' whereby files are copied into a directory that hasn't been created yet. Signed-off-by: Erez Odier <[email protected]> Signed-off-by: Erez Odier <[email protected]>
federicobozzini
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Apr 25, 2023
…pse-theia#11857) This adds a missing await to the 'mkdirp' call which fixes a potential race condition in 'doCopy' whereby files are copied into a directory that hasn't been created yet. Signed-off-by: Erez Odier <[email protected]> Signed-off-by: Erez Odier <[email protected]>
erezmus
added a commit
to ARMmbed/theia
that referenced
this pull request
May 11, 2023
…pse-theia#11857) This adds a missing await to the 'mkdirp' call which fixes a potential race condition in 'doCopy' whereby files are copied into a directory that hasn't been created yet. Signed-off-by: Erez Odier <[email protected]> Signed-off-by: Erez Odier <[email protected]>
CareyJWilliams
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Jun 22, 2023
…pse-theia#11857) This adds a missing await to the 'mkdirp' call which fixes a potential race condition in 'doCopy' whereby files are copied into a directory that hasn't been created yet. Signed-off-by: Erez Odier <[email protected]> Signed-off-by: Erez Odier <[email protected]>
CareyJWilliams
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Jun 23, 2023
…pse-theia#11857) This adds a missing await to the 'mkdirp' call which fixes a potential race condition in 'doCopy' whereby files are copied into a directory that hasn't been created yet. Signed-off-by: Erez Odier <[email protected]> Signed-off-by: Erez Odier <[email protected]>
erezmus
added a commit
to ARMmbed/theia
that referenced
this pull request
Aug 2, 2023
…pse-theia#11857) This adds a missing await to the 'mkdirp' call which fixes a potential race condition in 'doCopy' whereby files are copied into a directory that hasn't been created yet. Signed-off-by: Erez Odier <[email protected]> Signed-off-by: Erez Odier <[email protected]>
erezmus
added a commit
to ARMmbed/theia
that referenced
this pull request
Sep 12, 2023
…pse-theia#11857) This adds a missing await to the 'mkdirp' call which fixes a potential race condition in 'doCopy' whereby files are copied into a directory that hasn't been created yet. Signed-off-by: Erez Odier <[email protected]> Signed-off-by: Erez Odier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This fixes a potential race condition when copying files with directories. The call to
mkdirpwas not awaited, meaning that subsequent copying of files within the copied directory would occasionally fail as the directory creation had not finished.How to test
We found this issue while duplicating a project in ARM mbed-ide, so presumably, copying a large git project will suffice.
Review checklist
Reminder for reviewers