Plugin localization service does not await on init #11853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
BackendApplicationContribution#initialize
) of the localization service for plugins. With the proposed changes, the backend initialization does not wait for the cleaning of the localization cache folder.initialize
method fromPromise<void>
toMaybePromise<void>
not to force downstream projects to useaync
/Promise
when doing the customization.Why?
To speed up the backend startup when the Theia-based app is stated with multiple languages.
Originally from here:
How to test
Review checklist
Reminder for reviewers