Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: add deprecated withScmProgress #11798

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request adds the deprecated withScmProgress API to satisfy our compatibility report. Similarly to VS Code the API implementation is a no-op for progress in the source control location. The deprecated API is mainly implemented for backwards compatibility.

How to test

  • confirm that the API is marked as supported with the comparator report

image

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit adds the deprecated `withScmProgress` API for our
compatibility report. Like VS Code, the API is a no-op for progress in
the `Source Control` location.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility scm issues related to the source control manager labels Oct 25, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I can confirm that withScmProgress is supported by the API comparator with this change.

@vince-fugnitto vince-fugnitto merged commit de52cad into master Nov 8, 2022
@vince-fugnitto vince-fugnitto deleted the vf/deprecated-withScmProgress branch November 8, 2022 15:57
@github-actions github-actions bot added this to the 1.32.0 milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants