Check whether editor commands are declared in package.json #11764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11763 by checking whether commands registered via
registerTextEditorCommand
are declared inpackage.json
and registering only a handler, if so.How to test
clangd.typeHierarchy
orclangd.ast
are logged.clangd.ast
command still works as expected: right clicking in a C(++) editor should show aShow Ast
menu item, and clicking it should add a view container part to the Navigator that shows the AST at that place in the file.Review checklist
Reminder for reviewers