core: fix about dialog
#11687
Merged
core: fix about dialog
#11687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes the `about` dialog which is a `singleton` and once removed or closed will cause the dialog to be unmounted. The change ensures that if an `update-request` is sent to the widget we confirm first if the widget is mounted, and mount if not. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
dialogs
|
Alternatively we can make the |
The commit updates the `about` dialog to include additional information such as: - theia version - default vscode api - compatibility report link Signed-off-by: vince-fugnitto <[email protected]>
alvsan09
approved these changes
Sep 22, 2022
msujew
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #11669.
The pull-request fixes an issue where singleton react-dialogs cannot be updated after they have been closed since they are unmounted. The dialogs are mounted (constructor) and unmounted when closed but this poses a problem for singletons, where even if closed can be re-opened. The change ensures that if a react-dialog receives an update request we confirm that the dialog is first mounted, and if not, we mount it.
I included a secondary commit which enhances the
aboutdialog and includes some additional information:How to test
help>aboutxhelp>aboutReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]