Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markers: update problem decorations #11671

Merged
merged 1 commit into from
Sep 20, 2022
Merged

markers: update problem decorations #11671

merged 1 commit into from
Sep 20, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request updates our marker decorations for trees (most notably the navigator) to only render decorations for diagnostics with error or warning severity.

How to test

  1. include the following test plugin: code-actions-sample-0.0.2.vsix.zip.

  2. create a workspace folder that is not under version control (so we do not get git decorations).

  3. create a file in that folder

  4. use the created folder as the workspace

  5. in the file, type:

    1
    2
    3
    4
    
  6. each line in the file should produce a different severity diagnostic in the problems view:

Screen Shot 2022-09-15 at 6 00 16 PM
7. confirm the navigator has an error decoration for the file.
8. delete line 1 - confirm the navigator has a warning decoration for the file.
9. delete line 2 - confirm the navigator has no decorations for the file since there is none left that have a high enough severity.

Screen Shot 2022-09-15 at 6 02 28 PM

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit updates the `markers` decorations so they only apply decorations for `errors` and `warnings` similarly to vscode.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added navigator issues related to the navigator/explorer problems issues related to the problems widget labels Sep 15, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

  • Errors and warnings continue to display decorators in the navigator
  • Information diagnostics do not display decorators

@vince-fugnitto vince-fugnitto merged commit 825922a into master Sep 20, 2022
@vince-fugnitto vince-fugnitto deleted the vf/problems-nav branch September 20, 2022 12:06
@github-actions github-actions bot added this to the 1.30.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigator issues related to the navigator/explorer problems issues related to the problems widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants