markers: update problem decorations #11671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request updates our marker decorations for trees (most notably the navigator) to only render decorations for diagnostics with
error
orwarning
severity.How to test
include the following test plugin: code-actions-sample-0.0.2.vsix.zip.
create a workspace folder that is not under version control (so we do not get git decorations).
create a file in that folder
use the created folder as the workspace
in the file, type:
each line in the file should produce a different severity diagnostic in the
problems
view:7. confirm the navigator has an
error
decoration for the file.8. delete line
1
- confirm the navigator has awarning
decoration for the file.9. delete line
2
- confirm the navigator has no decorations for the file since there is none left that have a high enough severity.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]