open-editors: fix toolbar enablement and updates #11634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes the toolbar for the `open editors` tree-view to update properly: - the toolbar items are now always visible for the widget - the toolbar items are updated when there are changes with opened editors Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
requested review from
kenneth-marut-work and
colin-grant-work
Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/open-editors-toolbar
branch
from
44bd4b0 to
369f197
Compare
colin-grant-work
approved these changes
Sep 2, 2022
kenneth-marut-work
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vince-fugnitto [email protected]
What it does
Fixes: #11632.
The pull-request fixes the toolbar for the
open editorstree-view to update properly:How to test
open editorstree-view in theexplorerclose all editors- confirm the toolbar updates (becomes disabled)Review checklist
Reminder for reviewers