plugin-ext: remove conflicting shortcut ctrlcmd+shift+l #11608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could finally pass the ECA check. It took time because I used another email address. |
There was a problem hiding this comment.
@perrinjerome, thanks for the contribution. Would you mind adding a breaking change notice to the CHANGELOG since this is change in behavior that downstream applications may want to react to in their own ways.
perrinjerome
force-pushed
the
fix/pluginsView-keybinding-conflict
branch
from
ab75831 to
097fc49
Compare
|
@colin-grant-work thanks for the feedback and sorry for the delay in my reply. I have amended this commit to include a changelog entry the "breaking changes" section. Please take another look |
"Toggle plugin view" from theia's plugin-ext conflicts with "Select All Occurrences of Find Match" from monaco. "Toggle plugin view" is not a common action, so it does not need a keybinding by default Fixes eclipse-theia#11403 Signed-off-by: Jérome Perrin <[email protected]>
perrinjerome
force-pushed
the
fix/pluginsView-keybinding-conflict
branch
from
097fc49 to
48a888c
Compare
colin-grant-work
approved these changes
Sep 27, 2022
vince-fugnitto
added
keybindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Toggle plugin view" from theia's plugin-ext conflicts with "Select All
Occurrences of Find Match" from monaco.
"Toggle plugin view" is not a common action, so it does not need a
keybinding by default
Signed-off-by: Jérome Perrin [email protected]
What it does
Fixes #11403
How to test
fooReview checklist
Reminder for reviewers