Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application-manager: set the applicationName in title #11575

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request updates the frontend-generator to initially set the applicationName so we do not experience a flicker in name on startup, most notably when no workspace is present.

Before:

appname-flicker.mov

After:

appname.mov

How to test

  1. start the electron or browser application (confirm it works for both)
  2. with no workspace the applicationName should be present without the index.html flicker
  3. with a workspace present the applicationName should be present without the index.html flicker, and when the workspace is loaded should be in the format ${workspaceName} - ${applicationName}.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit updates the frontend generator to properly set the `applicationName` initially so we do not get a flicker (most notably from `index.html` to the actual name).

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Aug 16, 2022
@kittaakos
Copy link
Contributor

I have verified it from the sources (85db829), and it worked as described. Thank you!

verify_11575.mp4

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I can confirm that the changes work as expected 👍

@vince-fugnitto vince-fugnitto merged commit f3a81e7 into master Aug 19, 2022
@vince-fugnitto vince-fugnitto deleted the vf/applicationName branch August 19, 2022 15:09
@github-actions github-actions bot added this to the 1.29.0 milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants