-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace react-virtualized
with react-virtuoso
for React 18 compatibility
#11553
Conversation
55a4acf
to
efcb4ec
Compare
c8ea3e2
to
6690e11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tests look good 👍. I think I'd be inclined to merge sooner rather than later to give more time to catch any bugs.
(Though I'd also like CI to run and pass...) |
@colin-grant-work I'll rebase, but the 3PP dash license CI fails anyway, since the |
383b72f
to
ec2feee
Compare
@msujew it is probably fine to add it to our baseline for now given that the tool itself cannot parse the package's name. I do not see results for the package at that version on clearlydefined so we could also wait to see what Wayne says. |
@vince-fugnitto Yeah I also had troubles finding it on clearlydefined. But adjusting the URL did the trick for me and it shows as MIT only. See here. |
What it does
Fixes a problem which came up during the React 18 upgrade (#11455). Removes the need for the
react
resolutions and replaces the outdatedreact-virtualized
package with thereact-virtuoso
package. Although thereact-window
package is a spiritual successor to thereact-virtualized
dependency, it's missing many features which were needed for our tree rendering pipeline (namely measuring elements and caching these measurements).Also fixes #11376 accidentally in the process. I just wanted to test the "endless list" option of the
react-virtuoso
package.Also aligns the scrolling behavior of trees to vscode (it always scrolls selected elements into the center if they aren't visible).
@virtuoso.dev/urx
How to test
react-virtualized
.Review checklist
Reminder for reviewers