Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add toggle breadcrumbs command #11548

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Aug 9, 2022

What it does

The pull-request adds the command Toggle Breadcrumbs to control the enablement of the breadcrumbs.enabled preference. The changes also including adding an entry under the top-level View menu.

How to test

  1. start the application
  2. open an editor
  3. confirm that View: Toggle Breadcrumbs works well
  4. confirm that View > Toggle Breadcrumbs works well

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added the breadcrumbs issues related to breadcrumbs functionality label Aug 9, 2022
@vince-fugnitto vince-fugnitto self-assigned this Aug 9, 2022
@vince-fugnitto vince-fugnitto marked this pull request as ready for review August 9, 2022 18:16
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The new command updates the preference as expected. A minor issue, see below.

packages/core/src/browser/common-frontend-contribution.ts Outdated Show resolved Hide resolved
The commit adds the command `Toggle Breadcrumbs` to control the enablement of the `breadcrumbs.enabled` preference.
The changes also including adding an entry under the top-level `View` menu.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto merged commit c26f12e into master Aug 15, 2022
@vince-fugnitto vince-fugnitto deleted the vf/toggle-breadcrumbs branch August 15, 2022 13:22
@github-actions github-actions bot added this to the 1.29.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breadcrumbs issues related to breadcrumbs functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants