Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-center codeicons in the custom tree view #11542

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Fix off-center codeicons in the custom tree view #11542

merged 1 commit into from
Aug 19, 2022

Conversation

pluralia
Copy link
Contributor

@pluralia pluralia commented Aug 8, 2022 •
edited by vince-fugnitto
Loading

What it does

Closes #11273.
Centers spinning icons for the tree-view.

How to test

  1. Install the test extension (sources)
  2. Open the File Explorer tab -> Icons have to be centered (and spinning)

If no icons appear at all, change the File Icon Theme

Review checklist

Reminder for reviewers

msujew
msujew reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, doesn't this rather close #11273? Also, do you mind uploading a test extension to test your changes?

packages/plugin-ext/src/main/browser/style/tree.css Outdated Show resolved Hide resolved
@pluralia pluralia force-pushed the bugix/codicons-spinning branch from 98c345e to 7ab5c21 Compare August 8, 2022 11:12
@pluralia pluralia requested a review from msujew August 8, 2022 11:15
@msujew msujew added vscode issues related to VSCode compatibility ui/ux issues related to user interface / user experience labels Aug 8, 2022
vince-fugnitto
vince-fugnitto approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work as expected, the icons now spin properly:

Screen.Recording.2022-08-09.at.11.45.34.AM.mov

msujew
msujew approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well 👍

@msujew msujew merged commit cafdd77 into eclipse-theia:master Aug 19, 2022
@vince-fugnitto vince-fugnitto added this to the 1.29.0 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
ui/ux issues related to user interface / user experience vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.

Codicons spinning off-center in custom tree view
3 participants
@pluralia @msujew @vince-fugnitto