Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nls: do not localize open vsx registry #11523

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The commit updates the localization of the string Open VSX Registry which was previously translated by Theia.
Given that this is the official name of the service, localization for it's name should not happen.

Screen Shot 2022-08-03 at 4 27 35 PM

In other areas we correctly localize the registry:

placeholder={nls.localize('theia/vsx-registry/searchPlaceholder', 'Search Extensions in {0}', 'Open VSX Registry')}

Related: #11495.

How to test

  1. start the application
  2. open the extensions-view and search
  3. confirm that Open VSX Registry is not localized
  4. change languages using Configure Display Language
  5. confirm that Open VSX Registry is not localized for different languages

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit updates the localization for `Open VSX Registry`.
The name should not be localize as it is it's name.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added vsx-registry Issues related to Open VSX Registry Integration localization issues related to localization/internalization/nls labels Aug 3, 2022
@vince-fugnitto vince-fugnitto requested a review from msujew August 3, 2022 20:33
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto merged commit 6b71d94 into master Aug 8, 2022
@vince-fugnitto vince-fugnitto deleted the vf/vsx-localize branch August 8, 2022 14:17
@github-actions github-actions bot added this to the 1.29.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants